Skip to content

Updates gateway manifests for v1 InferencePool #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Updates gateway manifests for v1 InferencePool #1603

merged 1 commit into from
Sep 17, 2025

Conversation

danehans
Copy link
Contributor

Updates HTTPRoute manifests for all gateways other than GKE to use v1 InferencePool as a backendRef.

What type of PR is this?
/kind bug
/kind documentation

What this PR does / why we need it:

This PR is needed because a user cannot complete the quickstart guide for all gateways other than GKE. Additionally, we do not want to promote the alpha InferencePool API.

Which issue(s) this PR fixes:

Fixes #1602

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. labels Sep 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 34c478c
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c9fd7d5b7d900008e5ec04
😎 Deploy Preview https://deploy-preview-1603--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2025
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2025
@nirrozenbaum
Copy link
Contributor

would it be reasonable to update quickstart to use kgateway v2.1.0-dev until that release is finalized?
(and update to v2.1.0 after the release is cut)
ideally we want quickstart to work with all gateways by just following the steps.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit de97d60 into kubernetes-sigs:main Sep 17, 2025
11 checks passed
@danehans
Copy link
Contributor Author

@kfswain this PR should be backported to the release-1.0 branch and a v1.0.1 tag cut if #1604 is merged (versioned quickstart guide). Otherwise, users will continue to use the v1.0.0 manifests that contain bug #1602.

danehans added a commit to danehans/gateway-api-inference-extension that referenced this pull request Oct 15, 2025
@danehans
Updates gateway manifests for v1 InferencePool (kubernetes-sigs#1603)
3f23ffe 
Signed-off-by: Daneyon Hansen <[email protected]>
@danehans danehans mentioned this pull request Oct 15, 2025
Merged
k8s-ci-robot pushed a commit that referenced this pull request Oct 16, 2025
@danehans
Updates gateway manifests for v1 InferencePool (#1603) (#1732)
1683f61 
Signed-off-by: Daneyon Hansen <[email protected]>
@danehans danehans mentioned this pull request Oct 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elevran elevran Awaiting requested review from elevran

@kfswain kfswain Awaiting requested review from kfswain

Assignees

@nirrozenbaum nirrozenbaum

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: Quickstart Fails with Most Gateways

4 participants

@danehans @k8s-ci-robot @k8s-triage-robot @nirrozenbaum